fix: add Overview submodule for v13 module overview compatibility#94
fix: add Overview submodule for v13 module overview compatibility#94
Conversation
In TYPO3 v13, showSubmoduleOverview is not supported and the parent module redirects to the first submodule. Add an explicit Overview submodule as the first child so v13 shows the overview/dashboard page instead of the Secrets list. Signed-off-by: Sebastian Mendel <info@sebastianmendel.de>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a compatibility issue in TYPO3 v13 where clicking a parent module with submodules would automatically redirect to the first registered submodule, bypassing any intended overview page. By introducing an explicit "Overview" submodule and configuring it as the first entry, the change ensures that users consistently land on the overview dashboard in v13, while gracefully integrating as an additional menu item in v14 which handles overviews natively. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Automated approval for solo maintainer project
This PR has passed all automated quality gates:
- ✅ Static analysis (PHPStan)
- ✅ Code style (PHP-CS-Fixer)
- ✅ Unit & functional tests
- ✅ Security scanning
- ✅ Dependency review
See SECURITY_CONTROLS.md for compensating controls documentation.
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a compatibility fix for TYPO3 v13 by adding an explicit 'Overview' submodule. This ensures that users are directed to the overview page by default, which is a good solution for the behavior of dependsOnSubmodules in v13. The changes are well-commented and clearly explained. I have one suggestion to conditionally register this new submodule to improve long-term maintainability and avoid redundancy in newer TYPO3 versions.
1 participant
Summary
admin_vault_overviewsubmodule as the first child of theadmin_vaultparent moduleposition => ['before' => '*']to ensure it appears first in the module menudependsOnSubmodules => trueauto-redirects to the first submodule — this fix ensures users land on the Overview page instead of the Secrets submoduleshowSubmoduleOverview => truehandles this natively, so the new submodule simply becomes an additional entryProblem
TYPO3 v14 introduced
showSubmoduleOverviewwhich renders a module overview page when clicking the parent module. In v13, this feature doesn't exist — instead,dependsOnSubmodules => truecauses an auto-redirect to the first registered submodule. Without an explicit Overview submodule, users were redirected directly to Secrets, never seeing the overview dashboard.Test plan
showSubmoduleOverview)